fix: duplicate references for same signals#1503
Merged
marvinhagemeister merged 1 commit intomainfrom Jul 24, 2023
Merged
Conversation
lucacasonato
approved these changes
Jul 24, 2023
iuioiua
approved these changes
Jul 24, 2023
marvinhagemeister
force-pushed
the
fix-signal-serialization
branch
from
2ae67e1 to
19f7968
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two islands accessed the same signals we'd create two separate ones instead of pointing to the same signal reference upon deserialization in the client.
Fixes #1488 , Fixes preactjs/signals#389.