fix: duplicate @preact/signals version#2964
Conversation
2a5c87f to
2e31d03
Compare
Yes, and version ranges, e.g. |
|
I think tests will need to wait microtask/animation frame to match what Signals v2 had as breaking change. 🤔 Edit: @preact/signals@2.0.0
Edit 2: Perhaps using
Edit 3: Nvm, seems it was another issue, multiple different signal versions that may have been the issue 😅 |
|
Upstream Deno issue for |
Nah, only the |
| "@fresh/plugin-tailwind": "../plugin-tailwindcss/src/mod.ts", | ||
| "@luca/esbuild-deno-loader": "jsr:@luca/esbuild-deno-loader@^0.11.0", | ||
| "@preact/signals": "npm:@preact/signals@^1.3.0", | ||
| "@preact/signals": "npm:@preact/signals@^2.0.4", |
There was a problem hiding this comment.
Is it not possible to remove this dependency from here instead? Will that not use the same version as the root deno.json instead via workspaces?
There was a problem hiding this comment.
Yeah there is a PR for that #2900 . Was kinda hoping we could have support for workspace:* syntax similar to pnpm in Deno by now, but it looks like that is getting pushed on the back burner.
We initialized new projects with
@preact/signals@2.xbut Fresh itself was using1.x. There shall only ever be one version.Kinda makes me wish Deno had some sort of
peerDependencies.Fixes #2962