feat: support overwriting default 404 handler#3081
Merged
marvinhagemeister merged 2 commits intomainfrom Jul 8, 2025
Merged
Conversation
iuioiua
reviewed
Jul 8, 2025
Comment on lines
+248
to
+249
| * @param {() => Promise<Response>} [nextFn] overwrite default 404 handler | ||
| * @returns {Deno.ServeHandler} |
Contributor
There was a problem hiding this comment.
Nit: JSDoc types don't need to be defined since we're already using TypeScript
marvinhagemeister
added a commit
that referenced
this pull request
Jul 14, 2025
This reverts commit 0b3546f.
marvinhagemeister
added a commit
that referenced
this pull request
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1918