fix: active links consider query params and respect existing aria-current#3755
Merged
bartlomieju merged 4 commits intomainfrom Apr 9, 2026
Merged
fix: active links consider query params and respect existing aria-current#3755bartlomieju merged 4 commits intomainfrom
bartlomieju merged 4 commits intomainfrom
Conversation
…rent (#3474) - matchesUrl() now accepts an optional currentSearch parameter; when a link's href contains query params that don't match the current page, it returns Ancestor instead of Current - setActiveUrl() skips links that already have a user-set aria-current attribute, allowing frameworks like daisyUI to manage tabs - Client-side updateLinks() also respects user-set aria-current Closes #3474 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
matchesUrl()now considers query parameters — links with query params that don't match the current URL getAncestorinstead ofCurrentstatusaria-currentattribute are left untouched (both server and client side), fixing daisyUI tab components and similar use casesupdateLinks()passes search params and respects user-set attributesCloses #3474
Test plan
?sort=nameand?sort=priceon the same pathname are not both marked as currentaria-currenton an anchor is preserved🤖 Generated with Claude Code