Skip to content

refactor: simplified start proj logs#486

Merged
lucacasonato merged 3 commits intodenoland:mainfrom
iamsahilsonawane:main
Jul 15, 2022
Merged

refactor: simplified start proj logs#486
lucacasonato merged 3 commits intodenoland:mainfrom
iamsahilsonawane:main

Conversation

@iamsahilsonawane
Copy link
Contributor

Change

Improved the how to navigate and start your project logs after initialization.

Why this change?

In the previous state, it was harder for users:

  1. To know that these are commands
  2. To copy and paste that commands into the terminal

Inspiration

While creating Google Flutter's projects, it has a similar structure which makes it easier for copy-pasting in the terminal. When I came to fresh for the first time, it was a little hard for me to quickly catch them as commands.

Comparison (Before | After)

image

@xyntechx
Copy link
Contributor

Great idea! I saw that you're still using unresolvedDirectory for the cd command, which is good! The right-hand-side image you sent show cd hello_world though... it should be cd my-project if it's using unresolvedDirectory 😁

Minor nitpick but I hope it's just the image that's slightly wonky!

@iamsahilsonawane
Copy link
Contributor Author

iamsahilsonawane commented Jul 10, 2022

Great idea! I saw that you're still using unresolvedDirectory for the cd command, which is good! The right-hand-side image you sent show cd hello_world though... it should be cd my-project if it's using unresolvedDirectory 😁

Minor nitpick but I hope it's just the image that's slightly wonky!

Actually no, the unresolved directory gives us the name of the directory in which the project is been initialized. I created a project named, hello_world.

If you see the new updated code (not yet released), when you create a new project, you get the name of the directory in which you created the project.

So it's nothing changed, it's still the unresolved directory shown there in the 2nd image. Basically instead of giving us resolved directory which will be for e.g. Users/<username>/.../directory it gives us an unresolved directory which will be directory. my-project is a static log previously which soon got updated in this #415 pull.

@xyntechx
Copy link
Contributor

Great idea! I saw that you're still using unresolvedDirectory for the cd command, which is good! The right-hand-side image you sent show cd hello_world though... it should be cd my-project if it's using unresolvedDirectory 😁
Minor nitpick but I hope it's just the image that's slightly wonky!

Actually no, the unresolved directory gives us the name of the directory in which the project is been initialized. I created a project named, hello_world.

If you see the new updated code (not yet released), when you create a new project, you get the name of the directory in which you created the project.

So it's nothing changed, it's still the unresolved directory shown there in the 2nd image. Basically instead of giving us resolved directory which will be for e.g. Users/<username>/.../directory it gives us an unresolved directory which will be directory. my-project is a static log previously which soon got updated in this #415 pull.

Ah I see! Thanks for the clarification!

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@lucacasonato lucacasonato enabled auto-merge (squash) July 15, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants