Skip to content

refactor: move welcome plugin into middleware#714

Merged
kt3k merged 2 commits intodenoland:mainfrom
iuioiua:welcome-plugin
Jun 23, 2025
Merged

refactor: move welcome plugin into middleware#714
kt3k merged 2 commits intodenoland:mainfrom
iuioiua:welcome-plugin

Conversation

@iuioiua
Copy link
Copy Markdown
Contributor

@iuioiua iuioiua commented Jun 20, 2025

In hindsight, having this middleware in a plugin makes things more difficult to understand and doesn't provide much value. This change also works towards a Fresh 2 migration.

@iuioiua iuioiua marked this pull request as ready for review June 20, 2025 04:12
Copy link
Copy Markdown
Contributor

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 386a21a into denoland:main Jun 23, 2025
6 checks passed
@iuioiua iuioiua deleted the welcome-plugin branch June 23, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants