fix(testing/asserts): temporarily disable background colors in diff#2601
Merged
kt3k merged 2 commits intodenoland:mainfrom Sep 2, 2022
Merged
fix(testing/asserts): temporarily disable background colors in diff#2601kt3k merged 2 commits intodenoland:mainfrom
kt3k merged 2 commits intodenoland:mainfrom
Conversation
Member
|
Why didn't we just change the foreground text to be black? |
Member
Author
|
black text might work, but in my terminal (mac's default terminal app) white text also works
I think the problem here is that certain terminal renders green background too bright, and some terminal renders it darker. I think the correct solution is to use the more specific colors (by specifying color code) when the true color is available in that terminal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2575