chore(console): improve console test coverage #3839
Merged
+64
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
iuioiua
suggested changes
Nov 23, 2023
Contributor
iuioiua
left a comment
iuioiua
left a comment
There was a problem hiding this comment.
Thanks for this! Right direction. Just one suggestion for how runLengthTestCases is structured.
console/_rle_test.ts
Outdated
Comment on lines
6
to
22
| const runLengthTestCases: [number[], { d: string; r: string }, string][] = [ | ||
| [ | ||
| [1, 2, 3, 4, 5], | ||
| { d: "AQIDBAU=", r: "AQEBAQE=" }, | ||
| "return expected value if input is normal value", | ||
| ], | ||
| [ | ||
| [1, 1, 1, 1], | ||
| { d: "AQ==", r: "BA==" }, | ||
| "return expected value if input includes an continuous value", | ||
| ], | ||
| [ | ||
| [], | ||
| { d: "", r: "" }, | ||
| "return expected value if input is empty", | ||
| ], | ||
| ]; |
Contributor
There was a problem hiding this comment.
Are we able to turn this into an array of objects? It'd be a little easier to follow.
iuioiua
approved these changes
Nov 24, 2023
Contributor
iuioiua
left a comment
iuioiua
left a comment
There was a problem hiding this comment.
LGTM. Nice work. Thank you.
realpha
pushed a commit
to realpha/deno_std
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #3713
what I did
runLengthEncode()testrunLengthDecode()testcoverage change
https://app.codecov.io/gh/denoland/deno_std/commit/145c81a3c648f8c0d108f1517536cdfc0f487522/indirect-changes