chore(http): add test for file containing space in name #3892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
reviewed
Dec 4, 2023
Comment on lines
+160
to
+171
| await Deno.writeTextFile(filePath, text); | ||
|
|
||
| const req = new Request("http://localhost/test%20file.txt"); | ||
| const res = await serveDir(req, serveDirOptions); | ||
| const downloadedFile = await res.text(); | ||
|
|
||
| assertEquals(res.status, 200); | ||
| assertEquals( | ||
| res.headers.get("content-type"), | ||
| "text/plain; charset=UTF-8", | ||
| ); | ||
| assertEquals(downloadedFile, text); |
Member
There was a problem hiding this comment.
Can you surround these part with try {} block and call Deno.remove(filePath) in finally {} block? That structure avoids the leak of created file even when the test failed in the middle of the body.
Contributor
Author
There was a problem hiding this comment.
I instead added the file to .gitignore, along with the files from #3879. Let me know if you'd still like me to add in the try/catch blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3882 (review)