test(internal): improve test coverage #4779
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4779 +/- ##
==========================================
- Coverage 91.88% 91.72% -0.17%
==========================================
Files 486 486
Lines 41337 41325 -12
Branches 5325 5294 -31
==========================================
- Hits 37984 37905 -79
- Misses 3296 3357 +61
- Partials 57 63 +6 ☔ View full report in Codecov by Sentry. |
iuioiua
left a comment
iuioiua
left a comment
There was a problem hiding this comment.
Excellent work so far. This is great.
internal/build_message.ts
Outdated
| } | ||
|
|
||
| /** Used internally for testing. */ | ||
| export const _internals = { |
There was a problem hiding this comment.
Let's export these functions instead of putting them in these _internals objects. It'll be much cleaner. Ditto for the other files in this package. This is fine to do here as this is purely an internal package. You'll have to add @example tags to the newly exported symbols to make the doc checker (deno task lint:docs) too.
There was a problem hiding this comment.
gotcha!
for some reason i was unsure if we would ever want to export the other functions in this package.
implemented as suggested.
love the way how the doc checker works bth!
There was a problem hiding this comment.
Are you able to fix the functions in this file too?
There was a problem hiding this comment.
oh... i'm so sorry.
cleanup for build_message is done as well.
iuioiua
left a comment
iuioiua
left a comment
There was a problem hiding this comment.
Thank you very much for this. We should discuss and explore options for hitting that colors code.
2 participants
working towards #3713.
pushes code coverage of the
internalsub-module closer to 100%.the only file missing is
internal/styles.ts, which is vendored fromfmt/colors.ts.added a test case for
noColor, yet that doesn't seem to be sufficient to appease codecov.