Skip to content

Conversation

@lionel-rowe
Copy link
Contributor

Fixes #6852

@lionel-rowe lionel-rowe requested a review from kt3k as a code owner October 20, 2025 13:55
@github-actions github-actions bot added the http label Oct 20, 2025
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.08%. Comparing base (5e55eff) to head (4a3a236).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6853      +/-   ##
==========================================
- Coverage   94.08%   94.08%   -0.01%     
==========================================
  Files         578      578              
  Lines       42655    42654       -1     
  Branches     6782     6781       -1     
==========================================
- Hits        40134    40133       -1     
  Misses       2470     2470              
  Partials       51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k
Copy link
Member

kt3k commented Oct 21, 2025

Runtime change looks good to me. I'm not in favor of the type change. The change looks too breaking to the ecosystem to me. Also if a user prefers to get 'correct' type when accessing cookies['key'], they can enable noUncheckedIndexedAccess flag in their "compilerOption" (The same argument applies to the all Record-returning APIs in general)

@lionel-rowe lionel-rowe changed the title fix(http): runtime and TS types for getCookies fix(http): runtime types for getCookies Oct 21, 2025
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kt3k kt3k merged commit 9f9af1d into denoland:main Oct 21, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Runtime and TS types of getCookies are wrong

2 participants