Skip to content

chore: fmt#6886

Merged
dsherret merged 1 commit intodenoland:mainfrom
kt3k:chore-fmt
Nov 28, 2025
Merged

chore: fmt#6886
dsherret merged 1 commit intodenoland:mainfrom
kt3k:chore-fmt

Conversation

@kt3k
Copy link
Copy Markdown
Contributor

@kt3k kt3k commented Nov 28, 2025

deno fmt results have been slightly changed in canary and we need these changes. (probably affected by denoland/deno#31427)

@kt3k kt3k requested review from bartlomieju and dsherret November 28, 2025 06:48
@github-actions github-actions bot added the text label Nov 28, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.10%. Comparing base (9b2c51d) to head (9783814).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6886      +/-   ##
==========================================
- Coverage   94.11%   94.10%   -0.01%     
==========================================
  Files         581      581              
  Lines       42707    42707              
  Branches     6796     6796              
==========================================
- Hits        40194    40191       -3     
- Misses       2463     2465       +2     
- Partials       50       51       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

testUnicode(
"Lorem ipsum 𝌆 dolor sit ameͨ͆t.",
".teͨ͆ma tis rolod 𝌆 muspi meroL",
);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strange. Let me look into it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into it and it seems each string used to be a width of 29 in unicode-width 0.2.0 and now it's 30 in unicode-width 0.2.2: https://github.com/denoland/deno/pull/31427/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87eR9971

This seems ok because vscode considers this as a width of 31.

@dsherret dsherret merged commit 206ed42 into denoland:main Nov 28, 2025
19 checks passed
@kt3k kt3k deleted the chore-fmt branch November 30, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants