Skip to content

fix(fs/unstable): use crypto.getRandomValues() for temp file naming#6983

Merged
kt3k merged 1 commit intodenoland:mainfrom
tomas-zijdemans:math-random
Feb 16, 2026
Merged

fix(fs/unstable): use crypto.getRandomValues() for temp file naming#6983
kt3k merged 1 commit intodenoland:mainfrom
tomas-zijdemans:math-random

Conversation

@tomas-zijdemans
Copy link
Copy Markdown
Contributor

Make sure filenames aren't predictable

@tomas-zijdemans tomas-zijdemans requested a review from kt3k as a code owner February 4, 2026 08:58
@github-actions github-actions bot added the fs label Feb 4, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.26%. Comparing base (e80e6bb) to head (f69f7bb).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
fs/_utils.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6983      +/-   ##
==========================================
- Coverage   94.26%   94.26%   -0.01%     
==========================================
  Files         602      602              
  Lines       43662    43667       +5     
  Branches     7063     7063              
==========================================
+ Hits        41159    41161       +2     
- Misses       2447     2451       +4     
+ Partials       56       55       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Adding unstable in PR title as this seems only used by unstable APIs

@kt3k kt3k changed the title fix(fs): use crypto.getRandomValues() for temp file naming fix(fs/unstable): use crypto.getRandomValues() for temp file naming Feb 16, 2026
@kt3k kt3k merged commit 3c75917 into denoland:main Feb 16, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants