refactor(async/unstable): make circuit breaker resilient to throwing callbacks#6996
Merged
kt3k merged 3 commits intodenoland:mainfrom Feb 16, 2026
Merged
refactor(async/unstable): make circuit breaker resilient to throwing callbacks#6996kt3k merged 3 commits intodenoland:mainfrom
kt3k merged 3 commits intodenoland:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6996 +/- ##
=======================================
Coverage 94.20% 94.20%
=======================================
Files 613 613
Lines 47710 47725 +15
Branches 8299 8301 +2
=======================================
+ Hits 44945 44961 +16
Misses 2697 2697
+ Partials 68 67 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onFailure,onStateChange) would crash the circuit breaker mid-update, hiding the original error that your code was trying to throw.isFailure), so those results would never trip the circuit breaker