fix(http): handle HEAD requests in serveDir#7024
Merged
kt3k merged 2 commits intodenoland:mainfrom Mar 14, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7024 +/- ##
==========================================
+ Coverage 93.73% 94.02% +0.28%
==========================================
Files 620 627 +7
Lines 49388 50034 +646
Branches 8651 8809 +158
==========================================
+ Hits 46293 47042 +749
+ Misses 3025 2413 -612
- Partials 70 579 +509 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kt3k
reviewed
Mar 6, 2026
Contributor
|
Thanks for the PR. Left one comment |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serveDir()now accepts HEAD requests alongside GET, resolving the inconsistency whereserveFile()already supported HEAD butserveDir()returned 405serveDirIndex()returns a bodiless response with correctContent-Lengthfor HEAD requests on directory listingsCloses #6750
Supersedes #6752