refactor(crypto): harden and optimize timingSafeEqual()#7042
Open
tomas-zijdemans wants to merge 1 commit intodenoland:mainfrom
Open
refactor(crypto): harden and optimize timingSafeEqual()#7042tomas-zijdemans wants to merge 1 commit intodenoland:mainfrom
timingSafeEqual()#7042tomas-zijdemans wants to merge 1 commit intodenoland:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7042 +/- ##
=======================================
Coverage 94.01% 94.01%
=======================================
Files 627 627
Lines 50029 50031 +2
Branches 8807 8808 +1
=======================================
+ Hits 47037 47039 +2
Misses 2413 2413
Partials 579 579 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
WDYT @kitsonk? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeErrorinstead of returningfalse, matchingnode:crypto.timingSafeEqualbehaviour (this is a security issue with the current implementation. Every call should take the same amount of time regardless of whether the values match or not)DataView.getUint8()toUint8Arrayindexing. Twice as fast for typical hash digest sizes (32–64 bytes).DataViewfrom the parameter union type.DataViewalready satisfiesArrayBufferView, soDataViewinputs still work.while (++i)loop with standardforloop for readability.SharedArrayBufferinputs andTypeErroron length mismatch.