Skip to content

feat(data-structures): stabilize Deque#7092

Merged
bartlomieju merged 6 commits intodenoland:mainfrom
tomas-zijdemans:deque-stable
Apr 21, 2026
Merged

feat(data-structures): stabilize Deque#7092
bartlomieju merged 6 commits intodenoland:mainfrom
tomas-zijdemans:deque-stable

Conversation

@tomas-zijdemans
Copy link
Copy Markdown
Contributor

@tomas-zijdemans tomas-zijdemans commented Apr 12, 2026

I consider Deque to be feature-complete and the external API stable. We could add more functions like some, every or indexOf, but these are all convenience helpers that are addable post-stabilization as non-breaking additions, so not a reason to hold.

Follow-up to #7083, which deferred perf changes out of scope. This PR reapplies only the subset that is a pure internal refactor: toArray, includes, and #copyBuffer linearized into a two-pass walk. The iterator rewrite and Deque.from fast path from the original are intentionally omitted; they can be proposed separately if warranted.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.43%. Comparing base (a3a6ef6) to head (764b9bd).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7092   +/-   ##
=======================================
  Coverage   94.43%   94.43%           
=======================================
  Files         630      630           
  Lines       50566    50587   +21     
  Branches     8969     8974    +5     
=======================================
+ Hits        47750    47770   +20     
- Misses       2247     2248    +1     
  Partials      569      569           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit bd051c5 into denoland:main Apr 21, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants