add patch that reverts the import attributes removal#18
Merged
Conversation
github-actions bot
pushed a commit
that referenced
this pull request
Feb 15, 2025
This is a reland of commit 1827ed8 Before the change, one of the nodes had more than 2^16 inputs so optimization bailed out. After the change, the function has fewer parameters and gets optimized, and the register allocator struggles with that many parameters and times out. Just mark the test as slow for now. Original change's description: > Lower the maximum JS parameter count > > To allow extra implicit arguments on the call node without overflowing > the uint16_t input count, in particular in the wasm-to-js wrapper where > we don't have a bailout mechanism. > > R=verwaest@chromium.org > > Fixed: 394350433 > Change-Id: I61d2e2387539cafd6a0909c3ee035c93d0217be3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6239302 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/main@{#98556} (cherry picked from commit 84a0e23) Change-Id: Ib0fe3fbbd5dc544261312b6674ca76baa2ea4d56 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6268482 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/branch-heads/13.4@{#18} Cr-Branched-From: 0f87a54-refs/heads/13.4.114@{#1} Cr-Branched-From: 27af2e9-refs/heads/main@{#98459}
github-actions bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
Bug: 401428037 Fixed: 404769599 (cherry picked from commit a9f8323) Change-Id: Ida4cd347cc8303d5ed93528e46af7141cefbcfa2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6373605 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/branch-heads/13.5@{#18} Cr-Branched-From: c206c46-refs/heads/13.5.212@{#1} Cr-Branched-From: af3cadc-refs/heads/main@{#99020}
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2025
…ation Bug: 417169470 (cherry picked from commit 37d6fa3) Change-Id: Ib1b83f19f4a8ce52b844771e6bec1cefa31cfeb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6574467 Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Auto-Submit: Darius Mercadier <dmercadier@chromium.org> Commit-Queue: Darius Mercadier <dmercadier@chromium.org> Cr-Commit-Position: refs/branch-heads/13.7@{#18} Cr-Branched-From: dd5370d-refs/heads/13.7.152@{#1} Cr-Branched-From: fa9b753-refs/heads/main@{#99927}
github-actions bot
pushed a commit
that referenced
this pull request
Jun 9, 2025
…' objects Since the page can install accessors on various 'Error' prototypes, its possible to leak information from cross-origin scripts (via the inspector remote object). This CL fixes this particular instance by not creating remote objects for Errors where the 'SharedCrossOrigin' bit is not set in the originating script. Note that to do this, we have to find the right script and get it's origin info. We can't go via the debugger agent as it has not necessarily been enabled and so the script map in the debugger agent could be empty. Drive-by: There is one more oddity we don't fully understand. The scriptId passed via V8Inspector is set to 0 if it matches the top-most frame. This CL reverts this logic in the inspector, but this might break some expectation in DevTools. R=bmeurer@chromium.org (cherry picked from commit 907d1fa) Bug: 420885124 Change-Id: I3c1a7524349cdbadd6768f8c6bf5119d4b59369a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6623010 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Simon Zünd <szuend@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.8@{#18} Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1} Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
The asm parser often rewinds the scanner to re-parse the input. This is done in particular for switches and for-loops. To fix this issue once and for all, we now copy all characters into a vector of utf16 values and the `AsmScanner` works on that vector. We introduce a few helper functions in `AsmScanner` to make checking and consuming the next character easier. This actually made some scanning code significantly simpler. Drive-by: Put fields last in the `AsmScanner` class (see style guide). R=jkummerow@chromium.org Bug: 427918760 (cherry picked from commit c250ecf) Change-Id: I52dec42345481979b181c8de0745ca1fac3a4f4b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6718198 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/branch-heads/13.9@{#18} Cr-Branched-From: 76ea409-refs/heads/13.9.205@{#1} Cr-Branched-From: 2824212-refs/heads/main@{#100941}
github-actions bot
pushed a commit
that referenced
this pull request
Sep 23, 2025
While the memory buffer itself is managed off-heap, this builtin can allocate on-heap. (cherry picked from commit 5dd4e7c) Fixed: 445870128 Change-Id: Ifd17561b946e92ec1b1a1ac7a03b53b30ba976bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6973584 Commit-Queue: Matthias Liedtke <mliedtke@chromium.org> Auto-Submit: Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/branch-heads/14.0@{#18} Cr-Branched-From: 4ec2f43-refs/heads/14.0.365@{#1} Cr-Branched-From: a88b570-refs/heads/main@{#101731}
github-actions bot
pushed a commit
that referenced
this pull request
Oct 20, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8700501767591558977 Change-Id: I72da3da9afa1eddae8e4d04778980a42b10b5fc4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7060654 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.2@{#18} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
github-actions bot
pushed a commit
that referenced
this pull request
Nov 17, 2025
Prior to https://crrev.com/c/6974676, the non-const version of ForEachNestedRuntimeInput would update the slots_ table with the result of value->UnwrapIdentities (because the `value` pointer was passed by reference). This CL restores that behavior. In future work, we should refactor maglev's non-const ForEach functions to not do anything other than the expected iteration. We also DCHECK inside ForEachNestedRuntimeInput that identities have been unwrapped, and add CHECKs guarding DeoptInfo::input_locations iteration. (cherry picked from commit 6c83fb0) Bug: 458024244 Change-Id: I1482edbc3f351c1d2fbca82e05fd30121c6cdd18 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7124327 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Linke <jgruber@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#103572} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7136919 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.3@{#18} Cr-Branched-From: 13c7e31-refs/heads/14.3.127@{#1} Cr-Branched-From: 01af089-refs/heads/main@{#103352}
github-actions bot
pushed a commit
that referenced
this pull request
Dec 13, 2025
Bug: 466786677 (cherry picked from commit e0052e7) Change-Id: I6e8a6cae6aee58343fa0a760555aa00e5c799102 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7252675 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Darius Mercadier <dmercadier@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/branch-heads/14.4@{#18} Cr-Branched-From: 80acc26-refs/heads/14.4.258@{#1} Cr-Branched-From: ce7e597-refs/heads/main@{#104020}
github-actions bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
Version incremented at https://cr-buildbucket.appspot.com/build/8688404244862611937 Change-Id: Ie4ff2f953110e376a9110c0a3647388491df4290 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7624542 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.6@{#18} Cr-Branched-From: e04c3a1-refs/heads/14.6.202@{#1} Cr-Branched-From: 3b0b01e-refs/heads/main@{#105132}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.