Conversation
Cmd/Ctrl+B toggles a sidebar listing every changed file in a diff with its +/- counts. Clicking a file scrolls to it; the row for the file currently in view stays highlighted. The `:` palette gains a Files namespace that does the same jump by fuzzy search, hidden outside diff sessions. Navigation reads DiffMetadata.files, which was already on the wire and unused. deriveFileEntries() in src/lib/file-tree.ts is the single seam binding the sidebar to the diff wire model. Also fixes current-file tracking, which was wrong before this feature existed: useContentTracking derived the current file from hunk boundaries alone, but a file's header lines sit above its first hunk, so any header line resolved to the *previous* file — visible in the Header breadcrumb when scrolling a file header to the top of the viewport. A separate file-only ContentTracker now resolves currentFileIndex. hunkTracker is left hunk-only because useSelectionBounds walks its boundaries pairwise to clamp selections to a hunk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cmd/Ctrl+Btoggles a sidebar listing every changed file in a diff with its +/- counts. Clicking a file scrolls to it; the row for the file currently in view stays highlighted. The:palette gains a Files namespace that does the same jump by fuzzy search, hidden outside diff sessions.Also fixes current-file tracking:
useContentTrackingderived the current file from hunk boundaries alone, but a file's header lines sit above its first hunk, so any header line resolved to the previous file - visible in the Header breadcrumb when scrolling a file header to the top of the viewport. A separate file-onlyContentTrackernow resolvescurrentFileIndex.hunkTrackeris left hunk-only becauseuseSelectionBoundswalks its boundaries pairwise to clamp selections to a hunk.