Add solhint support#1192
Merged
Merged
Conversation
w0rp
requested changes
Dec 5, 2017
| \ { | ||
| \ 'lnum': 1, | ||
| \ 'col': 17, | ||
| \ 'text': 'Compiler version must be fixed (compiler-fixed)', |
Member
There was a problem hiding this comment.
Can you capture the error code at the end of the output and put it into the code key? Then the formatting for the error code will be configurable in ALE. Have a look at how this is handled for flake8 and ESLint.
Contributor
Author
There was a problem hiding this comment.
Updated, thanks for the feedback.
Contributor
Author
|
@w0rp Is the last commit what you suggested? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for solhint, a linter for the Solidity language.