Skip to content

Don't use temporary file for rustfmt fixer#1254

Merged
w0rp merged 1 commit into
dense-analysis:masterfrom
bkhl:master
Jan 2, 2018
Merged

Don't use temporary file for rustfmt fixer#1254
w0rp merged 1 commit into
dense-analysis:masterfrom
bkhl:master

Conversation

@bkhl

@bkhl bkhl commented Dec 27, 2017

Copy link
Copy Markdown
Contributor

rustfmt normally acts on a file in place, and applies configuration from rustfmt.toml files according to the path of the file.

Using a temporary file in /tmp/ for rustfmt breaks this functionality, so removing the '%t' from the rustfmt command.

rustfmt normally acts on a file in place, and applies configuration
from rustfmt.toml files according to the path of the file.

Using a temporary file for rustfmt breaks this functionality, so
removing the '%t' from the rustfmt command.

@w0rp w0rp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@w0rp w0rp merged commit e98a389 into dense-analysis:master Jan 2, 2018
@w0rp

w0rp commented Jan 2, 2018

Copy link
Copy Markdown
Member

Cheers! 🍻

w0rp added a commit that referenced this pull request Jan 2, 2018
Don't use temporary file for rustfmt fixer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants