Skip to content

Add lint_package support to lintr#1332

Merged
w0rp merged 1 commit into
dense-analysis:masterfrom
fennerm:master
Feb 5, 2018
Merged

Add lint_package support to lintr#1332
w0rp merged 1 commit into
dense-analysis:masterfrom
fennerm:master

Conversation

@fennerm

@fennerm fennerm commented Feb 4, 2018

Copy link
Copy Markdown
Contributor

Adds g:ale_lintr_lint_package flag for linting package with lintr::lint_package. #1245

@fennerm fennerm changed the title Add lint_package support to lintr #1245 Add lint_package support to lintr Feb 4, 2018

@w0rp w0rp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, looks fine to me.

@w0rp w0rp merged commit 91b7a75 into dense-analysis:master Feb 5, 2018
@w0rp

w0rp commented Feb 5, 2018

Copy link
Copy Markdown
Member

Cheers! 🍻

@fennerm

fennerm commented Feb 5, 2018

Copy link
Copy Markdown
Contributor Author

Hey I'm sorry but it turns out this code breaks when lint_package tries to change the working directory. Pretty sure I've got it fixed, I'll submit another pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants