Fix awk linter and security concerns.#1411
Merged
Merged
Conversation
w0rp
requested changes
Mar 9, 2018
w0rp
left a comment
w0rp
left a comment
Member
There was a problem hiding this comment.
Cool, add a test for the GetCommand function too in the test/command_callback directory. Add a comment explaining that the --source argument is there to prevent executing arbitrary code.
* Made it secure, albeit less useful. * Added gawk handler; the cpplint one was not working? * Added gawk handler test. * added warning to gawk handler. * added gawk command callback test * added comment about --source
Contributor
Author
|
Done, let me know if there are any other issues. note: I made some new changes/improvements. |
w0rp
requested changes
Mar 11, 2018
| \ get(g:, 'ale_awk_gawk_executable', 'gawk') | ||
|
|
||
| let g:ale_awk_gawk_options = | ||
| \ get(g:, 'ale_awk_gawk_options', '') |
Member
There was a problem hiding this comment.
We should keep these options, so people can set other options.
| @@ -0,0 +1,27 @@ | |||
| Before: | |||
Member
There was a problem hiding this comment.
Looks good. Add a test here to check that you can still set other options for gawk.
Contributor
Author
|
not sure how useful the command line options are. but re-added anyhow. |
w0rp
approved these changes
Mar 14, 2018
Member
|
Cheers! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1401