Add initial ameba (crystal linter) support#2174
Merged
w0rp merged 5 commits intodense-analysis:masterfrom Jan 27, 2019
Merged
Conversation
Member
|
Tests for the customization of the executable path would also be preferred. |
Contributor
Author
|
@RyanSquared Tests added in 6ebab91. |
RyanSquared
reviewed
Jan 2, 2019
RyanSquared
reviewed
Jan 2, 2019
Note that this depends on saved file as `ameba` does not have STDIN support
w0rp
requested changes
Jan 5, 2019
Swallows fewer unrelated errors
|
Hey @w0rp, any update here? Thank you guys for doing this. |
w0rp
approved these changes
Jan 27, 2019
Member
|
Cheers! 🍻 I'll additionally set |
Contributor
Author
|
Thanks @w0rp, @RyanSquared, and @veelenga! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this depends on the saved files as
amebadoes not have STDINsupport.
Tests have been added for handling the JSON output of
ameba. Let me know if you think additional tests are needed.