TSLint: distinguish warnings from errors#663
Merged
Merged
Conversation
w0rp
requested changes
Jun 18, 2017
w0rp
left a comment
w0rp
left a comment
Member
There was a problem hiding this comment.
Could you add a Vader test to cover this? Look at the existing tests for examples.
Contributor
Author
|
Added the test :) |
Member
|
Cheers! 🍻 |
Contributor
Author
|
By the way, wanted to tell you, this plugin is awesome, I'm positive in a year or so syntastic will be history :D |
Member
|
Syntastic was a great inspiration for this plugin, and LCD's comments on what to do for improving on what was there really helped a lot. With the help of others, eventually ALE should get support for all of the same linters and more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently TSLint linter displays everything as errors. After looking at the source code, I've modified the regex to detect tslint message type so that ALE can show warnings correctly.