Skip to content

Change regex to better handle messages with multiple groups of parentheses.#695

Merged
w0rp merged 1 commit into
dense-analysis:masterfrom
jsivak:feature/fix_multiple_parens
Jun 26, 2017
Merged

Change regex to better handle messages with multiple groups of parentheses.#695
w0rp merged 1 commit into
dense-analysis:masterfrom
jsivak:feature/fix_multiple_parens

Conversation

@jsivak

@jsivak jsivak commented Jun 26, 2017

Copy link
Copy Markdown
Contributor

With the symbolic name now displaying for pylint, I stumbled across some lint messages that contain multiple groups of ()'s.
Example actual output from pylint directly:
foo.py:34:4: W0702 (bare-except) No exception type(s) specified

message in vim as seen before the fix:
[pylint] W0702: specified (bare-except) No exception type(s) [Warning]

message in vim after the patch is applied:
[pylint] W0702: No exception type(s) specified (bare-except) [Warning]

(note, I have let g:ale_echo_msg_format = '[%linter%] %s [%severity%]' in my .vimrc)

This patch and test account for extra parentheses.

@w0rp w0rp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good to me.

@w0rp w0rp merged commit d2ec53f into dense-analysis:master Jun 26, 2017
@w0rp

w0rp commented Jun 26, 2017

Copy link
Copy Markdown
Member

Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants