Add GLSL linter using glslang#914
Merged
Merged
Conversation
svenstaro
commented
Sep 7, 2017
| | Go | [gofmt](https://golang.org/cmd/gofmt/), [go vet](https://golang.org/cmd/vet/), [golint](https://godoc.org/github.com/golang/lint), [gometalinter](https://github.com/alecthomas/gometalinter) !!, [go build](https://golang.org/cmd/go/) !!, [gosimple](https://github.com/dominikh/go-tools/tree/master/cmd/gosimple), [staticcheck](https://github.com/dominikh/go-tools/tree/master/cmd/staticcheck) | | ||
| | GraphQL | [gqlint](https://github.com/happylinks/gqlint) | | ||
| | Haml | [haml-lint](https://github.com/brigade/haml-lint) | ||
| | Haml | [haml-lint](https://github.com/brigade/haml-lint) | |
Contributor
Author
There was a problem hiding this comment.
Technically out of scope but I think this fixes a small markup problem.
w0rp
requested changes
Sep 7, 2017
w0rp
left a comment
w0rp
left a comment
Member
There was a problem hiding this comment.
Apart from the documentation error, this looks pretty good to me. 👍
| fusionscript..........................|ale-fuse-options| | ||
| fusion-lint.........................|ale-fuse-fusionlint| | ||
| glsl..................................|ale-glsl-options| | ||
| glslang.............................|ale-glsl-glslang| |
Member
There was a problem hiding this comment.
The Bash script pointed out that there's no tag for this doc tag link |ale-glsl-glslang|. I think the name is right here. You should make the heading name and the tag in doc/ale-glsl.txt match what you have here.
Contributor
Author
There was a problem hiding this comment.
Oh yeah I was apparently moving these things around at some point. The name here is the one I intended.
|
|
||
|
|
||
| =============================================================================== | ||
| glslangValidator *ale-glsl-glslangValidator* |
Member
There was a problem hiding this comment.
I recommend changing these to glslang and *ale-glsl-glslang*. See my other comment.
w0rp
approved these changes
Sep 8, 2017
Member
|
Cheers! 🍻 |
cwonrails
added a commit
to cwonrails/ale
that referenced
this pull request
Sep 9, 2017
* upstream/master: (30 commits) Add a Batch script for running tests on Windows Switch the AppVeyor clone directory to C:\testplugin Get some more random tests to work on Windows Fix the smoke_test.vader file on Windows Fix dense-analysis#912 - Close lists automatically when g:ale_open_list is set to 'on_save' again Add GLSL linter using glslang (dense-analysis#914) Add cuda nvcc linter (dense-analysis#874) Now remove the version command and the dummy file Add a blank file for testing AppVeyor Now try to cache Vim and Vader for AppVeyor CI Fix some PowerShell stderr BS Try and set up Vader only if needed too Fix some PowerShell syntax errors Try and set up AppVeyor so it will only download Vim if the directory is not there Try and get AppVeyor to run a single test Set up Vim runtime files in AppVeyor too Try and set up Vader in AppVeyor Try again Try different things for the Vim executable path Disable builds for AppVeyor ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a GLSL linter using glslang. Also fixes #592.