Luacheck: Respect warn_about_trailing_whitespace option#968
Merged
Conversation
w0rp
requested changes
Sep 30, 2017
w0rp
left a comment
w0rp
left a comment
Member
There was a problem hiding this comment.
Good idea. 👍
Could you modify the tests to check for this?
Contributor
Author
|
Sure thing, I updated the test to check if it leaves out the warning. |
w0rp
requested changes
Oct 1, 2017
w0rp
left a comment
w0rp
left a comment
Member
There was a problem hiding this comment.
You should leave the current test as-is, and add another case with the variable set to 0. Otherwise, you aren't testing if the variable has any effect.
Could you include some lines with each of the error codes you wish to filter out, and at least one you do not wish to filter out in the test? That should cover it.
adriaanzon
force-pushed
the
luacheck-whitespace
branch
from
4778038 to
1d1b515
Compare
Contributor
Author
|
Good idea 🙂 I finally found some time to sort this out. |
Member
|
Cheers! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See http://luacheck.readthedocs.io/en/stable/warnings.html, warnings 611 to 614.