get the original interfaces file and then append the link down commands#190
Merged
get the original interfaces file and then append the link down commands#190
Conversation
Signed-off-by: Chetan Murthy <muchetan@amazon.com>
mgheorghe
approved these changes
Mar 13, 2023
anton7811
reviewed
Mar 14, 2023
| device.applog.info("Getting the original interface file") | ||
| await device.scp(old_fname, "/etc/network/interfaces", remote_to_local=True, sudo=True) | ||
| # copy the original file. | ||
| shutil.copy(fname, old_fname) |
Contributor
There was a problem hiding this comment.
@muchetan You are replacing the recently copied file from the remote. Is this correct?
yuriilisovskyi
pushed a commit
to PLVision/dent-testing
that referenced
this pull request
Mar 30, 2023
…ds (dentproject#190) Signed-off-by: Chetan Murthy <muchetan@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in to order to fix issue 108