Skip to content

Bugfixes#380

Merged
vikumarks merged 9 commits intodentproject:mainfrom
PLVision:bugfixes
Aug 3, 2023
Merged

Bugfixes#380
vikumarks merged 9 commits intodentproject:mainfrom
PLVision:bugfixes

Conversation

@SerhiyBoikoPLV
Copy link
Copy Markdown
Contributor

@SerhiyBoikoPLV SerhiyBoikoPLV commented Jul 27, 2023 •
edited
Loading

  • Add more delay for ifupdown2 tests;
  • Split IPv6 verify_dut_neighbors function into verify_dut_neighbors and get_dut_neighbors;
  • Add cleanup_tgen fixture to the tests that use tgen traffic;
  • Clear Ixia sessions instead of reusing them. This will increase the time of the test runs, but it will make them more consistent.
  • Fix QoS and LLDP tests

@SerhiyBoikoPLV
Add sleep for ifupdown tests
ef4f4b5 
Sometimes the master interfaces don't have enough time
to be UP after reboot, so add a small delay.

Signed-off-by: Serhiy Boiko <serhiy.boiko@plvision.eu>
@SerhiyBoikoPLV
Split verify_dut_neighbors into two functions
2f3e51a 
Also ignore IPv6 mcast addresses.

Signed-off-by: Serhiy Boiko <serhiy.boiko@plvision.eu>
@SerhiyBoikoPLV
Add cleanup_tgen fixture to tests that are using tgen traffic
e48bcc3 
Signed-off-by: Serhiy Boiko <serhiy.boiko@plvision.eu>
@SerhiyBoikoPLV
Fix QoS default prio test
d15743c 
Add traffic from ports 2, 3, 4 so the fdb entries do not age.

At the end of the test the fdb entries for ports 2, 3, 4
are aged since there is no traffic from TG to them. Since
there is no fdb entries then any traffic from port 1 will
be flooded instead of forwarded. And since the traffic is
flooded the qdisc counters are counting extra packets which
causes the test to fail.

Signed-off-by: Serhiy Boiko <serhiy.boiko@plvision.eu>
@SerhiyBoikoPLV
Fix LLDP rx test
a2ff800 
Ixia cannot send traffic if the port is down. So, send
traffic only for one of the test cases.

Signed-off-by: Serhiy Boiko <serhiy.boiko@plvision.eu>
StepanVovkPLV and others added 3 commits July 31, 2023 07:20
@StepanVovkPLV @SerhiyBoikoPLV
Fix IGMP tests
b03a63f 
param should be passed as True/False instead of on/off

Signed-off-by: Stepan Vovk <stepan.vovk@plvision.eu>
Signed-off-by: Serhiy Boiko <serhiy.boiko@plvision.eu>
@SerhiyBoikoPLV
Fix L1 tests
b80f710 
Move traffic_generator_connect to beginning of the test, so
that tgen config is cleared and previous test does not affect
the current test

Signed-off-by: Serhiy Boiko <serhiy.boiko@plvision.eu>
@SerhiyBoikoPLV
Fix IPv4 random routing test
9d1a3fd 
Make sure that get_random_ip() does not produce
multicast or network addresses.

Signed-off-by: Serhiy Boiko <serhiy.boiko@plvision.eu>
@SerhiyBoikoPLV SerhiyBoikoPLV requested a review from vikumarks July 31, 2023 16:55
@SerhiyBoikoPLV
Fix IPv4 best match test
07a7651 
Give the port some time to be link up.

Signed-off-by: Serhiy Boiko <serhiy.boiko@plvision.eu>
@mgheorghe mgheorghe self-requested a review August 2, 2023 20:07
@vikumarks vikumarks merged commit 7494170 into dentproject:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgheorghe mgheorghe mgheorghe approved these changes

+1 more reviewer

@vikumarks vikumarks vikumarks approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SerhiyBoikoPLV @mgheorghe @vikumarks @StepanVovkPLV