Bugfixes for new Ixia card#389
Merged
mgheorghe merged 5 commits intodentproject:mainfrom Aug 15, 2023
Merged
Conversation
Signed-off-by: Stepan Vovk <stepan.vovk@plvision.eu>
Check that only 1 port supports the required speed. Signed-off-by: Serhiy Boiko <serhiy.boiko@plvision.eu>
Make sure tgen is not oversubscribed. Signed-off-by: Serhiy Boiko <serhiy.boiko@plvision.eu>
Tgen needs more time to calculate the correct traffic rate. Signed-off-by: Serhiy Boiko <serhiy.boiko@plvision.eu>
mgheorghe
approved these changes
Aug 15, 2023
| for row in stats.Rows: | ||
| err_msg = f"Expected 0.00 loss, actual {float(row['Loss %'])}" | ||
| assert tgen_utils_get_loss(row) == 0.000, err_msg | ||
| assert tgen_utils_get_loss(row) < 0.1, err_msg |
Contributor
There was a problem hiding this comment.
tolerances are good but sometimes dangerous
if rate is correct and all
why would any packet get lost?
for example whe na device is freshly booted and FDB is empty if you send too much traffic some devices will drop it.
but that can be fixed in script by sending a "learning" portion to alow FDB to be populated and than send the test traffic and expecting o loss
or if traffic is flowing, there can be packets in flight and tx will not perfectly match rx, but stoppi
any way this < 0.1 is solving the intermittent failures now but may hide real bugs in future.
vikumarks
approved these changes
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix tests that started failing after a new Ixia card was installed.