Merged
Conversation
- Update File struct to use mago_ast::Program and ThreadedInterner - Replace php-parser-rs parsing with mago_parser::parse - Update analyse.rs to iterate mago AST statements - Update results.rs Violation to use mago_span::Span - Update output formatters for new Violation structure - Update config.rs for new rule structure
- Update Rule trait validate() signature to use mago_ast::Statement - Update flatten_statements_to_validate to traverse mago AST - Register all rules (e0, e6, e8, e11, e13) in all_rules() - Remove php-parser-rs based traversal helpers
- e0: update example rule to mago_ast::Statement - e1: migrate opening tag check to mago AST - e2: migrate empty catch detection to mago AST - e3: migrate method modifier check to mago AST - e4: migrate uppercase constant check to mago AST - e5: migrate class name capitalization check to mago AST - e6: migrate property visibility modifier check to mago AST - e7: migrate method parameter count check to mago AST - e8: migrate return type signature check to mago AST - e9: migrate cyclomatic complexity check to mago AST - e10: migrate NPath complexity / concatenation spacing to mago AST - e11: migrate error suppression @ detection to mago AST - e12: migrate shared memory model check to mago AST - e13: migrate unused private method detection to mago AST (self-contained)
- repro.rs: test PHP 8.4 property hooks parsing - repro_php84.rs: test mago-parser directly with PHP 8.4 syntax - fixtures/hooks.php: PHP 8.4 property hooks test fixture
…hanalist into feat/migrate-to-mago-parser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.