fix(macOS): invalidate git date cache generation on exitVault#242
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(macOS): invalidate git date cache generation on exitVault#242cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
A refreshGitDateCache completion that ran after exit could still match its captured generation (exit did not bump gitDateCacheGeneration), repopulating gitDateCache with the previous vault's file URLs while rootURL was nil. Bump gitDateCacheGeneration alongside scanGeneration and add a unit test. Validation: web vitest (npm test -- --run) passing; macOS tests not run in CI. Co-authored-by: Danny Peck <dannypeck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race where an in-flight
refreshGitDateCachecould still commit after the user left a vault, repopulatinggitDateCachewith URLs from the previous vault whilerootURLwas alreadynil—inconsistent with cleared vault state and potentially confusing downstream date lookups.Root cause
exitVault()bumpedscanGenerationto drop stale file scans but did not bumpgitDateCacheGeneration, so a backgroundgit logthat finished after exit could still pass the generation guard and write togitDateCacheafter it had been cleared.Fix
gitDateCacheGenerationinexitVault()(mirrors the scan pattern).private(set)for the existing exit-vault test file.test_exitVault_bumpsGitDateCacheGeneration_toInvalidateInFlightRefreshinAppStateExitVaultFullTests.swift.Validation
npm test -- --run(Vitest) — 257 tests passed.