fix(macOS): surface true find match count when highlight cap applies#246
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(macOS): surface true find match count when highlight cap applies#246cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Find in note stops storing highlight ranges at 2000 for performance, but Replace All still replaced every occurrence. The status line only showed the capped count, so large notes could misstate scope and risk massive unintended replacements. Track full-document total alongside navigable (highlighted) count, update the find bar when totals diverge, and add unit tests for the match scan. Co-authored-by: Danny Peck <dannypeck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Find-in-note stores at most 2000 highlight ranges for performance, but Replace All still replaces every occurrence in the document. The status line only reflected the capped highlight count, so in large notes (e.g. a common letter or substring appearing thousands of times) users could believe far fewer matches existed than Replace All would touch—risking catastrophic unintended edits.
Changes
String.synapseSearchMatchRanges: single pass that returns capped ranges for highlights plus the full match count.AppState:searchMatchTotalalongside existing navigablesearchMatchCount/ index (still used for ⌘G wrapping within highlighted matches).FindBar: when total exceeds the highlighted cap, show e.g.5 / 2000 shown (8421 total).StringSearchMatchRangesTests: regression coverage for cap vs total behavior.Validation
vitestsuite (257 tests) passes (unchanged paths; sanity check).