fix(macOS): guard Replace against stale find highlight ranges#248
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(macOS): guard Replace against stale find highlight ranges#248cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Replace All previously fixed stale ranges before full-document replace; Replace Current could still call replaceCharacters with out-of-bounds NSRanges after a manual edit left cached highlight ranges invalid. Recompute highlights instead of crashing. Add regression test. Co-authored-by: Danny Peck <dannypeck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Replace (single-match replace in the in-note find bar) could crash the macOS app with
NSRangeExceptionwhen the cached search highlight ranges were no longer valid for the current document length.Root cause
reapplySearchHighlights()skips out-of-bounds ranges when repainting after markdown restyle, but it does not updatelastSearchHighlightRanges. After the user edits the note (e.g. deletes text before a match), Replace still used the staleNSRangefromlastSearchHighlightRangesinreplaceCharacters(in:with:), which throws when the range exceeds the storage length.Fix
NSMaxRange(range) <= storage.length; if stale, callapplySearchHighlightsto resync from the live document instead of mutating text.FindReplaceStaleHighlightTestsand wire it into the Xcode project.Validation
test_replaceCurrentMatch_afterEditInvalidatesCachedRange_doesNotCrash(AppKit / XCTest; run in Xcode on macOS).REPO_RULES.md).