docs: Document default for CLI --data#6359
Merged
jeremylong merged 1 commit intodependency-check:mainfrom Jan 14, 2024
marcelstoer:patch-1
Merged
docs: Document default for CLI --data#6359jeremylong merged 1 commit intodependency-check:mainfrom marcelstoer:patch-1
jeremylong merged 1 commit intodependency-check:mainfrom
marcelstoer:patch-1
Conversation
Collaborator
|
This is not always correct. The path to the data directory is relative to the location of the install directory: I could unzip the CLI anywhere on the system - it will have: When executed the data directory would be generated right next to the bin directory: |
Collaborator
Author
|
Hhmm...I see. The fact that my data dir is |
Collaborator
|
Correct |
Collaborator
Author
|
Shall I update the PR and try to summarize what I learned through these comments? Or did you not document the defaults on purpose in which case I'll close it. |
Collaborator
|
Please, update the PR. The documentation can always improve and with 9.x
more people will lokely need to figure out where the default location is.
…On Thu, Jan 4, 2024, 3:04 PM Marcel Stör ***@***.***> wrote:
Shall I update the PR and try to summarize what I learned through these
comments? Or did you not document the defaults on purpose in which case
I'll close it.
—
Reply to this email directly, view it on GitHub
<jeremylong/DependencyCheck#6359 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGSVQRCX2C7IB2E73D552DYM4DOTAVCNFSM6AAAAABBNCYW66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZXGY4TAOJQGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
jeremylong
approved these changes
Jan 14, 2024
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue
n/a
Description of Change
It took me a while to figure out what the default data dir for the CLI app is.
Have test cases been added to cover the new functionality?
n/a