feat: Remove the need to specify dbDriver for external databases using JDBCv4 ServiceLoader supporting JDBC drivers#6938
Merged
jeremylong merged 3 commits intomainfrom Sep 5, 2024
Merged
Conversation
Collaborator
|
ack - merge conflicts that will likely take using beyond compare to figure out ;) |
Collaborator
Author
|
@jeremylong I'll work on rebasing it to get rid of them... most likely effect of my editor autoformatting the file on edit |
…llow JDBC4 classpath based loading using JDBC 4 ServiceLoader
… JDBC driver from classpath
Collaborator
Author
|
IntelliJ IDEA with ignoring whitespace made the merge-conflict resolution easily.... a typo fix and addition of a missing path were the conflicting changes |
jeremylong
approved these changes
Sep 5, 2024
Collaborator
|
Beyond Compare's diff would have been similar - if you ever have to diff a lot of code I always prefer using BC4. It is hands down the best diff tool available. |
Collaborator
Author
|
Up to now I've been quite satisfied with the 3-way merge of IntelliJ IDEA for resolving merge conflicts, but I do know that BeyondCompare is also a strong tool though I've never used it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #6937
Description of Change
Have test cases been added to cover the new functionality?
no, a sensible test would require an external database server. Used the local test-project that surfaced the issue for validating the solution working with an external database. Existing test-cases proof that the removal of the dbDriver configuration is not affecting the use of the embedded h2 database (as the H2 driver is also fully supporting the JDBCv4 ServiceLoader mechanism).