Skip to content

chore: update some of the major dependencies#146

Merged
joscha merged 1 commit intodependents:mainfrom
XhmikosR:dev-major
Mar 15, 2022
Merged

chore: update some of the major dependencies#146
joscha merged 1 commit intodependents:mainfrom
XhmikosR:dev-major

Conversation

@joscha
Copy link
Copy Markdown
Collaborator

@joscha joscha commented Mar 14, 2022

references #145

@joscha joscha requested a review from XhmikosR March 14, 2022 05:39
@joscha
Copy link
Copy Markdown
Collaborator Author

joscha commented Mar 14, 2022

CC @XhmikosR - ready to merge. We should probably bump the major version with this. might not actually be needed, as compat is not changed and the package name doesn't change. The NPM token will need to be updated however.

Actually, can you give me config rights on this repo, please? I can't see the settings any longer. Ta!

@XhmikosR
Copy link
Copy Markdown
Member

@joscha thanks, I gave you admin rights here :)

That being said, don't merge this yet. I'll split this PR so that we can land the non-breaking changes separately. I should be able to do it later today.

@joscha
Copy link
Copy Markdown
Collaborator Author

joscha commented Mar 14, 2022

Great! Is there a npm group for dependents?

@XhmikosR
Copy link
Copy Markdown
Member

There is but I'd need to dig in to see if I have admin rights there :)

@XhmikosR XhmikosR marked this pull request as draft March 14, 2022 12:30
@XhmikosR XhmikosR changed the title chore: update references and major versions chore: update major versions Mar 14, 2022
@XhmikosR
Copy link
Copy Markdown
Member

@joscha I split the patches. There is an npm organization (https://www.npmjs.com/org/dependents) but I don't have admin rights, so we need @mrjoelkemp to add you/move the package there too.

@XhmikosR XhmikosR marked this pull request as ready for review March 14, 2022 12:39
@XhmikosR
Copy link
Copy Markdown
Member

After this is merged, you can merge the other dep PRs assuming they don't break anything and release a new major version version :)

@XhmikosR XhmikosR changed the title chore: update major versions chore: update some of the major dependencies Mar 14, 2022
@mrjoelkemp
Copy link
Copy Markdown

@XhmikosR Made you an owner of the npm org. The UI to manage that org is so confusing on npm. Figured it out.

@joscha joscha merged commit d3919a9 into dependents:main Mar 15, 2022
@joscha
Copy link
Copy Markdown
Collaborator Author

joscha commented Mar 15, 2022

@XhmikosR Made you an owner of the npm org. The UI to manage that org is so confusing on npm. Figured it out.

@XhmikosR are you able to produce an NPM_TOKEN and add it to the secrets in the settings of this project, please: https://github.com/dependents/node-detective-postcss/settings/secrets/actions/NPM_TOKEN ? After that I can create the new 6.0.0 release.

@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Mar 15, 2022

@joscha @mrjoelkemp I have no idea how to move a package to the npm org :/

@mrjoelkemp can you make @joscha an admin of the detective-postcss package?

BTW the token doesn't need to change in theory.

@XhmikosR XhmikosR deleted the dev-major branch March 15, 2022 06:16
@joscha
Copy link
Copy Markdown
Collaborator Author

joscha commented Mar 15, 2022

I revoked all tokens after I moved the repo but didn't have admin access anymore. I can't really leave my token in a shared public org as I can't limit the access, so I'd prefer if you created one for repo if you don't mind.

@XhmikosR
Copy link
Copy Markdown
Member

OK, I think we need @mrjoelkemp to give you admin rights to the detective-postcss repo after it's moved to the npm org so that you can manage it independently

@joscha
Copy link
Copy Markdown
Collaborator Author

joscha commented Mar 15, 2022 via email

@XhmikosR
Copy link
Copy Markdown
Member

BTW v5.1.0 is broken :/

Error: Cannot find module 'C:\Users\xmr\Desktop\detective\node-precinct\node_modules\detective-postcss\dist\index.js'. Please verify that the package.json has a valid "main" entry

We'll need to cut a new 5.1.1 release before 6.0.0.

@joscha
Copy link
Copy Markdown
Collaborator Author

joscha commented Mar 15, 2022 via email

@XhmikosR
Copy link
Copy Markdown
Member

Definitely worth adding a new action to test this if you have some time later :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants