chore: update some of the major dependencies#146
chore: update some of the major dependencies#146joscha merged 1 commit intodependents:mainfrom XhmikosR:dev-major
Conversation
|
CC @XhmikosR - ready to merge. Actually, can you give me config rights on this repo, please? I can't see the settings any longer. Ta! |
|
@joscha thanks, I gave you admin rights here :) That being said, don't merge this yet. I'll split this PR so that we can land the non-breaking changes separately. I should be able to do it later today. |
|
Great! Is there a npm group for dependents? |
|
There is but I'd need to dig in to see if I have admin rights there :) |
|
@joscha I split the patches. There is an npm organization (https://www.npmjs.com/org/dependents) but I don't have admin rights, so we need @mrjoelkemp to add you/move the package there too. |
|
After this is merged, you can merge the other dep PRs assuming they don't break anything and release a new major version version :) |
|
@XhmikosR Made you an owner of the npm org. The UI to manage that org is so confusing on npm. Figured it out. |
@XhmikosR are you able to produce an NPM_TOKEN and add it to the secrets in the settings of this project, please: https://github.com/dependents/node-detective-postcss/settings/secrets/actions/NPM_TOKEN ? After that I can create the new 6.0.0 release. |
|
@joscha @mrjoelkemp I have no idea how to move a package to the npm org :/ @mrjoelkemp can you make @joscha an admin of the detective-postcss package? BTW the token doesn't need to change in theory. |
|
I revoked all tokens after I moved the repo but didn't have admin access anymore. I can't really leave my token in a shared public org as I can't limit the access, so I'd prefer if you created one for repo if you don't mind. |
|
OK, I think we need @mrjoelkemp to give you admin rights to the detective-postcss repo after it's moved to the npm org so that you can manage it independently |
|
I can give access to the package to an org or user.
…On Tue, 15 Mar 2022, 17:24 XhmikosR, ***@***.***> wrote:
OK, I think we need @mrjoelkemp <https://github.com/mrjoelkemp> to give
you admin rights to the detective-postcss repo after it's moved to the npm
org so that you can manage it independently
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABN5BWCHM7PWF5U7IVQBF3VAAUJ3ANCNFSM5QUPDRQA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
BTW v5.1.0 is broken :/ We'll need to cut a new 5.1.1 release before 6.0.0. |
|
👍
Wonder if it's worth to add a pack and require check before publishing to
avoid errors like these in the future.
…On Tue, 15 Mar 2022, 17:32 XhmikosR, ***@***.***> wrote:
BTW v5.1.0 is broken :/
Error: Cannot find module 'C:\Users\xmr\Desktop\detective\node-precinct\node_modules\detective-postcss\dist\index.js'. Please verify that the package.json has a valid "main" entry
We'll need to cut a new 5.1.1 release before 6.0.0.
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABN5BUZ2MOSFPNXYZDPK2DVAAVGFANCNFSM5QUPDRQA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Definitely worth adding a new action to test this if you have some time later :) |
references #145