Conversation
* return early * use a ternary * be explicit when calling function * use array includes
joscha
approved these changes
Apr 6, 2024
Collaborator
joscha
left a comment
joscha
left a comment
There was a problem hiding this comment.
LGTM. I think the readability is not necessarily better with the ternaries, but it's down to personal preference, I suppose.
Member
Author
|
I can revert those changes if you prefer, just let me know
…On Sat, Apr 6, 2024, 11:25 Joscha Feth ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM. I think the readability is not necessarily better with the
ternaries, but it's down to personal preference, I suppose.
—
Reply to this email directly, view it on GitHub
<#272 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNIMX74MIFX7IYQ7PCTY36WO3AVCNFSM6AAAAABF2E6YHOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOBUGQ3DGNRXGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
They're fine, thanks for caring! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-whitespace diff: https://github.com/dependents/node-detective-postcss/pull/272/files?w=1