Disabling default_timeout for run/runLocally has no effect

[alexgit2k]

For disabling the timeout for run/runLocally default_timeout should be set to null: https://deployer.org/docs/7.x/recipe/common#default_timeout

Example:

<?php
namespace Deployer;

set('default_timeout', null);

localhost('test');

task('sleep5', function () {
  run('sleep 5');
});
task('sleep10', function () {
  run('sleep 10');
});
task('sleep500', function () {
  run('sleep 500');
});

But dep sleep500 still quits at the default timeout of 300 seconds.
However, it looks like setting it to 0 instead of null is disabling the timeout: set('default_timeout', 0);

Occurrences:

deployer/recipe/common.php

Line 53 in a14383b

// Set to `null` to disable timeout.

deployer/src/functions.php

Line 349 in a14383b

* @param int|null $timeout Sets the process timeout (max. runtime). The timeout in seconds (default: 300 sec; see {{default_timeout}}, `null` to disable).

deployer/docs/api.md

Line 230 in a14383b

| `$timeout` | `int` or `null` | Sets the process timeout (max. runtime). The timeout in seconds (default: 300 sec; see {{default_timeout}}, `null` to disable). |

Upvote & Fund

• We're using Polar.sh so you can upvote and help fund this issue.
• We receive the funding once the issue is completed & confirmed by you.
• Thank you in advance for helping prioritize & fund our backlog.

[lamasfoker]

I can confirm the issue. I think the problem is in \Deployer\run function:

    foreach (['timeout', 'idle_timeout', 'secret', 'env', 'real_time_output', 'no_throw'] as $arg) {
        if ($$arg !== null) {
            $namedArguments[$arg] = $$arg;
        }
    }

and in \Deployer\runLocally function:

    foreach (['timeout', 'idle_timeout', 'secret', 'env', 'shell'] as $arg) {
        if ($$arg !== null) {
            $namedArguments[$arg] = $$arg;
        }
    }

The if statement in the loops removes the timeout parameter passed to the function.

[antonmedv]

Setting to 0 disables the timeout.

[github-actions]

This issue has been automatically closed. Please, open a discussion for bug reports and feature requests.

Read more: [https://github.com//discussions/3888]