Run deploy:writable again after cache warmup #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in ticket #575 the cache is not writable after the deployment of symfony if the deployment-user is not the httpd-user. Therefore we would make the cache-directory writable again after the cache-warmup. This is necessary because symfony may not do that and the deploy user should know who is able to write into the cache. You can finally define this by using `set('writable_dirs', […])` and `set('http_user', '…')`.
Member
|
I think ok. @oanhnn? @deployphp/maintainer ? |
|
I think you don't need to duplicate deploy:writable task. We only needed deploy:writable after 'deploy:cache:warmup'. I tested and everything is ok. |
Member
Contributor
Author
|
You are totally right, so I changed the task as suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in ticket #575 the cache is not writable after the deployment of symfony if the deployment-user is not the httpd-user. Therefore we would make the cache-directory writable again after the
cache-warmup. This is necessary because symfony may not do that and the deploy user should know who is able to write into the cache. You can finally define this by using
set('writable_dirs', […])andset('http_user', '…').