Skip to content

Conversation

@mficzel
Copy link
Contributor

@mficzel mficzel commented Nov 4, 2016

Q A
Bug fix? No
New feature? Yes
BC breaks? No
Deprecations? No
Fixed tickets N/A

With this recipe projects based on the Flow-Framework (https://flow.neos.io/) and Neos-CMS (https://www.neos.io) can be deployed.

@mficzel
Copy link
Contributor Author

mficzel commented Nov 4, 2016

I file this pr against master because in the past new base-recipes were often added in dot-releases. If requested i will gladly rebase on 4.x.

@antonmedv
Copy link
Member

I think it's can be separate repo with this recipe.

@mficzel
Copy link
Contributor Author

mficzel commented Nov 4, 2016

It is a base recipe like those for laravel, symfony or typo3 wich are part of the main deployer-repository, that is why i think this belongs here.

In a separate repo the projects using this would either copy the recipe-file or use a custom deployer build wich both is a hurdle.

With this recipe projects based on the Flow-Framework (https://flow.neos.io/) and Neos-CMS (https://www.neos.io) can be deployed.
@mficzel mficzel force-pushed the feature/addFlowFrameworkRecipe branch from aac276f to b431a81 Compare November 7, 2016 07:24
@antonmedv
Copy link
Member

Closing as fameless.

@antonmedv antonmedv closed this Nov 8, 2016
@mficzel
Copy link
Contributor Author

mficzel commented Nov 10, 2016

@Elfet what would make this not fameless ... creating an issue and collecting +1 comments?

@antonmedv
Copy link
Member

antonmedv commented Nov 10, 2016

@mficzel community.

@antonmedv
Copy link
Member

Why you don't want to create separate project with your recipe for your framework?

@mficzel
Copy link
Contributor Author

mficzel commented Nov 10, 2016

@Elfet Just to make it clear. Flow is not my personal framework it has some community around europe (especially germany) and is already some years old.

I am part of the neos and flow team but i am still pretty new there. In that role i work on making the use easier for new users ... supporting deployer is part of that.

Maybe a clarification about how contributing to deployer works and what kind of code is welcome would help. I do'nt want to steal your time with pr's that do'nt go in and would rather compile the needed informations you need beforehand.

@mficzel
Copy link
Contributor Author

mficzel commented Nov 11, 2016

Maybe some statistics are interesting here:

Note: The namespace typo3 will be removed from the project in the future this was started as a typo3-rewrite but grew to a seperate project.

@antonmedv
Copy link
Member

Looks like a lot (118 388) installs.
I think we can add it. I'm planing to find some solution for management a lot of recipes.

@antonmedv antonmedv reopened this Nov 11, 2016
@antonmedv antonmedv merged commit a299ab4 into deployphp:master Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants