Allow subfolders copy #898
Conversation
henriquebremenkanp
commented
Nov 22, 2016
henriquebremenkanp
commented
| Q | A |
|---|---|
| Bug fix? | Yes |
| New feature? | No |
| BC breaks? | No |
| Deprecations? | No |
| Fixed tickets | #896 |
|
Looks like it should fix the problem I saw - I'll give it a run tomorrow when I'm back at work. |
|
|
||
| // Copy shared dir files if they does not exist. | ||
| run("if [ -d $(echo {{release_path}}/$dir) ]; then cp -rn {{release_path}}/$dir $sharedPath; fi"); | ||
| run("if [ -d $(echo {{release_path}}/$dir) ]; then cp -rn {{release_path}}/$dir $sharedPath/$parentDir; fi"); |
There was a problem hiding this comment.
On second look - would I want anything copied from my release path into my shared storage once shared storage is established? Seems like possible risk of unwanted / unexpected overwrite if I happen to have placeholder in my release tree. For example, if my release tree contained a shell sqlite DB file that I want to be shared/retained across releases, this copy would always reset back to the release tree version.
Maybe the copy from release tree should only be if $sharedPath/$dir doesn't yet exist? Your prior ticket indicated this change was trying to repair a first time deploy issue.
There was a problem hiding this comment.
Nevermind - I now the the -n option on cp that prevents overwrite.
There was a problem hiding this comment.
Your prior ticket indicated this change was trying to repair a first time deploy issue.
This is true. And i think to add this later, and remove -n flag (#894).
3 participants
