Skip to content
This repository was archived by the owner on Apr 26, 2020. It is now read-only.

Add Discord recipe#177

Merged
antonmedv merged 8 commits into
deployphp:masterfrom
lucasmezencio:discord
Apr 20, 2018
Merged

Add Discord recipe#177
antonmedv merged 8 commits into
deployphp:masterfrom
lucasmezencio:discord

Conversation

@lucasmezencio
Copy link
Copy Markdown
Contributor

Q A
Bug fix? No
New feature? Yes
BC breaks? No
Deprecations? No
Fixed tickets N/A

Add Discord recipe. 🙂

@joubertredrat
Copy link
Copy Markdown

This sound good, I use deployer and have discord server, then, why not?

Comment thread src/Discord/Messaging.php Outdated
@@ -0,0 +1,59 @@
<?php

namespace Deployer\Discord;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be done without using extra classes?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @antonmedv! I think yes, but why?
I mean, I think that separating things could be a good way to organise the code.
What do you think?
🙂

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but not v6 have some problems with autoloading and phars. I'm going to solve this in future version bout to work correctly on all version of deployer now must not include composer autoload.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonmedv got you! Thanks!

I'll update my code then. :)

@lucasmezencio
Copy link
Copy Markdown
Contributor Author

Hey @antonmedv do you think it's doable to do something like this? 🙂

@lucasmezencio
Copy link
Copy Markdown
Contributor Author

@antonmedv hey, news? 🙂

@antonmedv
Copy link
Copy Markdown
Member

Please, remove MessagingInterface and all classes, it's redundant. :)

@lucasmezencio
Copy link
Copy Markdown
Contributor Author

@antonmedv ok then. Let's go! 😋

@lucasmezencio
Copy link
Copy Markdown
Contributor Author

@antonmedv oh sorry! I need to update the README.

@lucasmezencio
Copy link
Copy Markdown
Contributor Author

@antonmedv done!

@antonmedv antonmedv merged commit d889eb4 into deployphp:master Apr 20, 2018
@lucasmezencio lucasmezencio deleted the discord branch April 20, 2018 12:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants