This repository was archived by the owner on Apr 26, 2020. It is now read-only.
cachetool recipe: add cachetool_bin setting to download old version (…#184
Merged
Conversation
…4.0.0 is only compatible with php >=7.1)
Member
|
Why just don't update phar? |
Contributor
Author
|
What do you mean by "just update phar"? |
Member
|
You proper phar tool :) |
antonmedv
reviewed
May 23, 2018
|
|
||
| set('cachetool', ''); | ||
| set('cachetool_bin', function(){ | ||
| return run("/usr/bin/php -r \"echo version_compare(phpversion(), '7.1') == -1 ? 'cachetool-3.2.1.phar' : 'cachetool.phar';\""); |
Member
There was a problem hiding this comment.
Where is cachetool-3.2.1.phar should come?
Member
There was a problem hiding this comment.
It's better to use {{bin/php}} instead of /usr/bin/php.
Contributor
Author
|
It is hosted a the same place as cachetool.phar :)
…On Wed 23 May 2018 at 14:39, Anton Medvedev ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In recipe/cachetool.php
<#184 (comment)>:
> @@ -8,6 +8,9 @@
namespace Deployer;
set('cachetool', '');
+set('cachetool_bin', function(){
+ return run("/usr/bin/php -r \"echo version_compare(phpversion(), '7.1') == -1 ? 'cachetool-3.2.1.phar' : 'cachetool.phar';\"");
Where is *cachetool-3.2.1.phar* should come?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#184 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABlI21cbPLKezcCnw5RBcgefpan-CF4vks5t1ViCgaJpZM4UKGmc>
.
|
antonmedv
suggested changes
May 23, 2018
|
|
||
| set('cachetool', ''); | ||
| set('cachetool_bin', function(){ | ||
| return run("/usr/bin/php -r \"echo version_compare(phpversion(), '7.1') == -1 ? 'cachetool-3.2.1.phar' : 'cachetool.phar';\""); |
Member
There was a problem hiding this comment.
It's better to use {{bin/php}} instead of /usr/bin/php.
| namespace Deployer; | ||
|
|
||
| set('cachetool', ''); | ||
| set('cachetool_bin', function(){ |
Contributor
Author
|
Done! |
antonmedv
approved these changes
May 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…4.0.0 is only compatible with php >=7.1)