Skip to content
This repository was archived by the owner on Apr 26, 2020. It is now read-only.

Allow messages to be complex on Discord recipe#185

Merged
antonmedv merged 3 commits into
deployphp:masterfrom
lucasmezencio:fix-complex-messages
May 25, 2018
Merged

Allow messages to be complex on Discord recipe#185
antonmedv merged 3 commits into
deployphp:masterfrom
lucasmezencio:fix-complex-messages

Conversation

@lucasmezencio
Copy link
Copy Markdown
Contributor

@lucasmezencio lucasmezencio commented May 24, 2018

Q A
Bug fix? Yes
New feature? No
BC breaks? No
Deprecations? No
Fixed tickets N/A

Do not forget to add notes about your changes to CHANGELOG.md


Hey @chapterjason thanks a lot for your previous fix, but it ended up to unable user to send 'complex' messages, just like this:

set('discord_notify_text', function () {
    return [
        'attachments' => [
            [
                'title' => get('application') . ' Application Has Started Deploying...',
                'fields' => [
                    [
                        'title' => 'Environment',
                        'value' => get('stage'),
                        'short' => true
                    ],
                    [
                        'title' => 'Branch',
                        'value' => get('branch') ?: 'master',
                        'short' => true
                    ],
                    [
                        'title' => 'Deployer',
                        'value' => get('user'),
                        'short' => true
                    ],
                ],
            ],
        ],
    ];
});

Because you set every single message as text. So I'm writing this PR just to get back to default messages with the text index in case user don't want to send complex messages. 🙂

@antonmedv let me know if you agree with this. Thank you guys!

@lucasmezencio lucasmezencio changed the title Allow messages to be complex Allow messages to be complex on Discord recipe May 24, 2018
@chapterjason
Copy link
Copy Markdown
Contributor

Hey, I didn't know that was possible, but good to know. 👍

Copy link
Copy Markdown
Contributor

@chapterjason chapterjason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lucasmezencio
Copy link
Copy Markdown
Contributor Author

@chapterjason yay! 🎉

@antonmedv antonmedv merged commit eab3b3b into deployphp:master May 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants