Retry acquiring builder if the first attempt results in an error#35
Merged
jacobwgillespie merged 1 commit intomainfrom May 24, 2022
Merged
Retry acquiring builder if the first attempt results in an error#35jacobwgillespie merged 1 commit intomainfrom
jacobwgillespie merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have seen some spurious network issues cause the CLI to be unable to acquire a builder connection within the timeout.
Before making any more involved changes, this PR adds one retry phase, so if the first attempt to acquire a builder fails, it is retried once before being reported as an error. So that the CLI doesn't wait any longer than it does currently, the timeout for acquiring a connection is now 30 seconds rather than 60, so the retry will happen half-way through the previous window.