Skip to content

chore: migrate cmd - reverse order of next steps when secrets detected#479

Merged
lukevmorris merged 1 commit intomainfrom
andrea/reorder-migrate-cmd-output
Apr 9, 2026
Merged

chore: migrate cmd - reverse order of next steps when secrets detected#479
lukevmorris merged 1 commit intomainfrom
andrea/reorder-migrate-cmd-output

Conversation

@andie787
Copy link
Copy Markdown

@andie787 andie787 commented Apr 9, 2026

This PR changes the output of the depot ci migrate command:

  • when secrets or variables are detected, the Next steps are reversed to suggest 1)importing secrets and vars 2) push and merge to default branch
  • this means the first workflow run has a better chance of passing

Note

Low Risk
Low risk: only adjusts depot ci migrate console messaging/step numbering, with no changes to migration logic or API calls.

Overview
Updates depot ci migrate "Next steps" output so that when secrets/variables are detected it now instructs users to import secrets/vars first (step 1) and activate workflows by merging to the default branch second (step 2). When no secrets/vars are found, it prints only the activation instruction (without numbered steps).

Reviewed by Cursor Bugbot for commit 8963b45. Bugbot is set up for automated code reviews on this repo. Configure here.

@andie787 andie787 requested a review from lukevmorris April 9, 2026 00:03
}
} else {
if defaultBranch != "" {
fmt.Fprintf(out, " Activate these workflows by pushing and merging them into %s\n", bold.Render(defaultBranch))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing step number prefix. When no secrets or variables are detected, the instruction should be numbered as step 1 for consistency with the other code path.

fmt.Fprintf(out, "  1. Activate these workflows by pushing and merging them into %s\n", bold.Render(defaultBranch))
Suggested change
fmt.Fprintf(out, " Activate these workflows by pushing and merging them into %s\n", bold.Render(defaultBranch))
fmt.Fprintf(out, " 1. Activate these workflows by pushing and merging them into %s\n", bold.Render(defaultBranch))

Spotted by Graphite

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disagree!

@lukevmorris lukevmorris merged commit de44a95 into main Apr 9, 2026
15 checks passed
@lukevmorris lukevmorris deleted the andrea/reorder-migrate-cmd-output branch April 9, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants