chore: migrate cmd - reverse order of next steps when secrets detected#479
Merged
lukevmorris merged 1 commit intomainfrom Apr 9, 2026
Merged
chore: migrate cmd - reverse order of next steps when secrets detected#479lukevmorris merged 1 commit intomainfrom
lukevmorris merged 1 commit intomainfrom
Conversation
| } | ||
| } else { | ||
| if defaultBranch != "" { | ||
| fmt.Fprintf(out, " Activate these workflows by pushing and merging them into %s\n", bold.Render(defaultBranch)) |
Contributor
There was a problem hiding this comment.
Missing step number prefix. When no secrets or variables are detected, the instruction should be numbered as step 1 for consistency with the other code path.
fmt.Fprintf(out, " 1. Activate these workflows by pushing and merging them into %s\n", bold.Render(defaultBranch))
Suggested change
| fmt.Fprintf(out, " Activate these workflows by pushing and merging them into %s\n", bold.Render(defaultBranch)) | |
| fmt.Fprintf(out, " 1. Activate these workflows by pushing and merging them into %s\n", bold.Render(defaultBranch)) |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
lukevmorris
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the output of the
depot ci migratecommand:Note
Low Risk
Low risk: only adjusts
depot ci migrateconsole messaging/step numbering, with no changes to migration logic or API calls.Overview
Updates
depot ci migrate"Next steps" output so that when secrets/variables are detected it now instructs users to import secrets/vars first (step 1) and activate workflows by merging to the default branch second (step 2). When no secrets/vars are found, it prints only the activation instruction (without numbered steps).Reviewed by Cursor Bugbot for commit 8963b45. Bugbot is set up for automated code reviews on this repo. Configure here.