feat: allow user to import shortlist with --secrets and --vars#481
Merged
lukevmorris merged 2 commits intomainfrom Apr 10, 2026
Merged
feat: allow user to import shortlist with --secrets and --vars#481lukevmorris merged 2 commits intomainfrom
lukevmorris merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Adds new CLI flags and proto fields that change the request contract for
ImportSecretsAndVars; risk is mainly compatibility if the server/client versions diverge or filtering is misapplied, but scope is limited to the migration flow.Overview
Adds support for importing only a shortlisted set of GitHub Actions secrets/variables during
depot ci migrate secrets-and-vars.The command now accepts
--secretsand--vars(repeatable) and forwards these lists through theImportSecretsAndVarsAPI (including dry-run preview). The MigrationServiceImportSecretsAndVarsRequestproto is extended withinclude_secretsandinclude_varsfields (and regenerated Go bindings).Reviewed by Cursor Bugbot for commit 501543d. Bugbot is set up for automated code reviews on this repo. Configure here.