Merged
Conversation
WitoDelnat
approved these changes
May 6, 2026
goller
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
step_key, optionalstep_id, and optionalstep_nameon log linesstep_keystep_key,step_id, andstep_namein JSON and NDJSON log output while leaving plain log output unchanged. this is particularly useful for visualizing and parsing parallel steps.Verification
make generategofmt -w pkg/api/ci.go pkg/api/ci_test.go pkg/cmd/ci/logs.go pkg/cmd/ci/logs_test.gogo test ./pkg/api ./pkg/cmd/cigo test ./...git diff --checkDepends on: https://github.com/depot/api/pull/3637
Linear: DEP-4399
Note
Medium Risk
Changes the
LogLineprotobuf schema and JSON log output fields (renaming the primary correlation field and adding new metadata), which may impact downstream consumers expecting the oldstep_idsemantics.Overview
Updates CI log lines to carry a stable Depot correlation key (
step_key) plus optional user-authoredstep_id/step_namein the v1 protobuf (ci.protoregen).Adjusts log streaming de-dupe to key on
step_keyinstead ofstep_id, and extendsdepot ci logs --output json/NDJSON events to includestep_key,step_id, andstep_namewhile leaving plain text output unchanged (tests updated accordingly).Reviewed by Cursor Bugbot for commit 3f084b7. Bugbot is set up for automated code reviews on this repo. Configure here.